Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fake.rb may use different RUBY_PLATFORM. #39

Merged
merged 1 commit into from May 4, 2011

Conversation

Projects
None yet
2 participants
Owner

kou commented May 4, 2011

We can custom build platform via Rake::ExtensionTask#cross_platform= but fake.rb always use "i386-mingw32". If we custom cross_platform to not "i386-mingw32" platform, fake.rb also fakes us. :<

Contributor

luislavena commented May 4, 2011

Hehe, agree :)

Was looking into an example where you're using this and found rroonga:

ranguba/rroonga@d3a3b8b

I'm going to apply this, but hope you remember that 64bits MinGW (cross compiler) still don't have a working RubyInstaller (64bits version) distributed, so you might not want to distribute 64bits binaries yet

Unless I'm missing the picture?

luislavena added a commit that referenced this pull request May 4, 2011

Merge pull request #39 from kou/master.
fake.rb may use different RUBY_PLATFORM.

@luislavena luislavena merged commit 44aeeed into rake-compiler:master May 4, 2011

Owner

kou commented May 4, 2011

Thanks your fast response! Wow!

I'm going to apply this, but hope you remember that 64bits MinGW (cross compiler) still don't have a working RubyInstaller (64bits version) distributed, so you might not want to distribute 64bits binaries yet

I know it. :-)
So my next action is that sending a patch for RubyInstaller's 64bits support to you.

I have a patch to make Ruby trunk buildable with x86_64-w64-mingw32-gcc:
http://pub.cozmixng.org/~kou/archives/ruby-trunk-x86_64-w64-mingw32.diff

But I don't make sure whether the patch is correct or not. e.g. it may break i586-mingw32msvc-gcc support. What do you think about it?

(Should we move other place?)

Contributor

luislavena commented May 4, 2011

So my next action is that sending a patch for RubyInstaller's 64bits support to you.

I have a patch to make Ruby trunk buildable with x86_64-w64-mingw32-gcc:
http://pub.cozmixng.org/~kou/archives/ruby-trunk-x86_64-w64-mingw32.diff

Interesting, I've built Ruby trunk last night for 64bits without issues:

https://gist.github.com/954581

I think we can move this conversation to RubyInstaller: http://groups.google.com/group/rubyinstaller/

One thing to mention is that compiling Ruby or cross compiling it to target 64bits is not the problem, the problem is still all the dependencies Ruby have (libiconv, libffi, libyaml) and the successful compilation in 64bits of them.

Work has started in that front, but help will be highly appreciated ;-)

Contributor

luislavena commented May 4, 2011

As for:

But I don't make sure whether the patch is correct or not. e.g. it may break i586-mingw32msvc-gcc support. What do you think about it?

rake-compiler correctly sets the platform using --target during the configure process. Is a bummer that Debian/Ubuntu added the msvc suffix.

Anyhow, would love you bring this topic to RubyInstaller list ;-)

Owner

kou commented May 4, 2011

Interesting, I've built Ruby trunk last night for 64bits without issues:

Really!? Uhmm...

I think we can move this conversation to RubyInstaller: http://groups.google.com/group/rubyinstaller/

I send a mail to the list. Please tell me about dependencies problem at the list. :-)

rake-compiler correctly sets the platform using --target during the configure process. Is a bummer that Debian/Ubuntu added the msvc suffix.

I'm sorry. I should explain about it.
The patch changes .def file generation on MinGW build. It uses both MinGW and MinGW-w64. I just test it with MinGW-w64. I didn't test it with MinGW. So we may fail to build Ruby with MinGW and the patch.
(If .def is generated correctly, we will fail to build Ruby.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment