Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Emit JRuby cross-compile warning only when actually doing the cross-compilation #45

Merged
merged 1 commit into from Oct 5, 2011

Conversation

Projects
None yet
2 participants
Contributor

jfirebaugh commented Aug 7, 2011

Previously it was emitted when running any rake task or even just rake -T.

Contributor

luislavena commented Aug 19, 2011

Thank you!

Will merge it soon (now that isolate works)

Contributor

jfirebaugh commented Oct 1, 2011

Bump? I'd like to get this fixed before pushing out a new version of ruby-debug, as the warning can be somewhat alarming.

Contributor

luislavena commented Oct 2, 2011

This will only affect people doing the compilation of ruby-debug or any extension that uses rake-compiler, not end-user. Don't see how that affects your release.

Will get this merged and prep for a new release over tomorrow.

Contributor

jfirebaugh commented Oct 2, 2011

Thanks Luis -- you're right, the warning is produced at gem package time but not gem install time.

@luislavena luislavena added a commit that referenced this pull request Oct 5, 2011

@luislavena luislavena Merge pull request #45 from jfirebaugh/jruby_warning
Only emit warnings when doing cross-compilation tasks
f80313e

@luislavena luislavena merged commit f80313e into rake-compiler:master Oct 5, 2011

Contributor

luislavena commented Oct 5, 2011

Thank you!, this landed in f80313e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment