Convert forward slashes to backslashes on windows #5
Conversation
This fixes panda on windows.
|
I have mixed feelings about this one, and it's been here for so long, because it feels weird to me that .relative is a almost a no-op here but converts slashes. Does .IO.path achieve the same result, could we use that instead? Again, sorry to keep it open for so long. |
Not sure how relevant, but one of the ideas of the newio branch is to only expose forward slashes at the P6 level. Liz |
|
Okay, I've slacked off for full 4 months with this, and I figured it's time to accept it :) Here's a thing though: as a default, $exclude is False, so Bool. In tests it's an Array of Str, and here it's used as a single Str :) I will typify the API properly and pull this change in along with it. |
|
Ok, I decided to make it a user's responsibility after all. I fixed it in panda with tadzik/panda@6cbf3f1 and also fixed File::Find's tests and documentation to underline and verify that: 522363b Can you confirm that it fixes the issue for you and whether you agree with the change? :) |
|
Works for me! Panda has been working on Windows again, which is mostly what I cared about. |
|
Okay, awesome :) Thanks! |
This fixes panda on windows.