Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken on Windows 2018.06 #26

Closed
stmuk opened this issue Aug 6, 2018 · 3 comments
Closed

Broken on Windows 2018.06 #26

stmuk opened this issue Aug 6, 2018 · 3 comments

Comments

@stmuk
Copy link

stmuk commented Aug 6, 2018 

I ran into a problem while trying to set up Linenoise: Must specify something as a path: did you mean '.' for the current directory?
Continuing without tab completions or line editor
@hoelzro
Copy link
Collaborator

hoelzro commented Aug 7, 2018

@stmuk This reminds me of #24 - did you happen to see if my fix back in June fixed that issue on Windows? If it didn't, then I'm guessing it's related to that; if it did, I'll start investigating elsewhere.

@hoelzro
Copy link
Collaborator

hoelzro commented Aug 10, 2018

@stmuk This should be all fixed on master now!

@hoelzro hoelzro closed this as completed Aug 10, 2018
@stmuk
Copy link
Author

stmuk commented Aug 10, 2018

👍

stmuk referenced this issue in rakudo/rakudo Aug 12, 2018
@ugexe
Revert "Use $*SPEC.dir-sep for separators in CompUnit::RepositoryRegi…
d8d51d0 
…stry"

This reverts commit c3e1ec0.

First, I do not understand why changing the directory separator should be needed as internally it doesn't matter anywhere else. Second, things like `"inst#$prefix/vendor` are not paths ( its a cur spec ) so changing them explicitly seems strange -- we don't use `$*SPEC.dir-sep;` for meta6 provides data for instance. Third, the line `@binaries = flat @installations.map: { .script("bin{$sep}$script", :$name) };` will not work because we made a sha1 earlier from a forward slash variant https://github.com/rakudo/rakudo/blob/e5568aa5023843c6e1cbd6e845a3bfe735b81486/src/core/CompUnit/Repository/Installation.pm6#L377 which essentially breaks all installed bin scripts on windows.

I'm not sure what problem this intended to solve, but this is likely not the spot to go about solving it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hoelzro @stmuk