Switch the infix:<=> op to use the perl6 assignment opcode directly

instead of going through a sub to do it. This results in a 29% speed improvement on a simple while $count < 100000 { $count++ } benchmark.
rakudo · Jun 22, 2011 · 1bb9b53 · 1bb9b53
1 parent 9ccc8eb
commit 1bb9b53
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/Perl6/Grammar.pm b/src/Perl6/Grammar.pm
@@ -2105,8 +2105,8 @@ grammar Perl6::Grammar is HLL::Grammar {
     token infix:sym<=> {
         <sym>
         [
-        || <?{ $*LEFTSIGIL eq '$' }> <O('%item_assignment, :reducecheck<assign_check>')>
-        || <O('%list_assignment, :reducecheck<assign_check>')>
+        || <?{ $*LEFTSIGIL eq '$' }> <O('%item_assignment, :reducecheck<assign_check>, :pirop<perl6_container_store__0PP>')>
+        || <O('%list_assignment, :reducecheck<assign_check>, :pirop<perl6_container_store__0PP>')>
         ]
     }
 

diff --git a/src/core/operators.pm b/src/core/operators.pm
@@ -4,7 +4,7 @@
 ##   Int/Rat/Num operators are in {Int|Rat|Num}.pm
 
 sub infix:<=>(Mu \$a, Mu \$b) {
-    pir::perl6_container_store__0PP($a, pir::perl6_decontainerize__PP($b))
+    pir::perl6_container_store__0PP($a, $b)
 }
 
 
diff --git a/src/ops/perl6.ops b/src/ops/perl6.ops
@@ -506,7 +506,8 @@ otherwise, calls the .STORE method.
 
 */
 inline op perl6_container_store(in PMC, in PMC) :base_core {
-    Rakudo_cont_store(interp, $1, $2, 1, 1);
+    Rakudo_cont_store(interp, $1, 
+        Rakudo_cont_decontainerize(interp, $2), 1, 1);
 }
 
 
@@ -523,7 +524,8 @@ already decided that it's safe).
 
 */
 inline op perl6_container_store_unchecked(in PMC, in PMC) :base_core {
-    Rakudo_cont_store(interp, $1, $2, 0, 0);
+    Rakudo_cont_store(interp, $1, 
+        Rakudo_cont_decontainerize(interp, $2), 0, 0);
 }