From 2cda7a19e633861b6af5b69759f71d0e80cca07c Mon Sep 17 00:00:00 2001
From: Tom Browder <tbrowde@dedi2>
Date: Sun, 13 May 2018 07:28:28 -0500
Subject: [PATCH] Fix for GH #1821: unexpected table failure

The failure was unexpected because the failure message
reported mixed visual and non-visual column separators
but such were not seen. The fix was to properly
detect trailing visual column separators.

Tests have been added for the fix.

Additional changes:

+ turn off unsolicited warnings for tables violating
  best practices (but code just commented out for now)
+ typo fix
---
 src/Perl6/Pod.nqp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/Perl6/Pod.nqp b/src/Perl6/Pod.nqp
index 83f8f454246..b30ade01818 100644
--- a/src/Perl6/Pod.nqp
+++ b/src/Perl6/Pod.nqp
@@ -398,7 +398,7 @@ class Perl6::Pod {
 
     our sub normalize_text($a) {
         # given a string of text, possibly including newlines, reduces
-        # contiguous whitespace to a single space and trim leading and
+        # contiguous whitespace to a single space and trims leading and
         # trailing whitespace from all logical lines
         my $r := subst($a, /\s+/, ' ', :global);
         $r    := subst($r, /^^\s*/, '');
@@ -606,8 +606,8 @@ class Perl6::Pod {
         # row separator
         my $is_row_sep   := /^ <[-+_|=\h]>* $/;
         # legal row cell separators
-        my $col_sep_pipe := /\h '|' \h/; # visible
-        my $col_sep_plus := /\h '+' \h/; # visible
+        my $col_sep_pipe := /\h '|' \h | \h '|' $/; # visible
+        my $col_sep_plus := /\h '+' \h | \h '+' $/; # visible
         my $col_sep_ws   := /\h \h/;     # invisible: double-space
 
         my $has_vis_col_sep  := / $col_sep_pipe | $col_sep_plus /;
@@ -912,11 +912,13 @@ class Perl6::Pod {
                 nqp::say($_) for @rows; # the original table as input
                 nqp::say("===end WARNING table $t input rows");
             }
+            =begin comment
             elsif $warns && $show_warning {
                     nqp::say("===WARNING: One or more tables evidence bad practice.");
                     nqp::say("==          Set environment variable 'RAKUDO_POD_TABLE_DEBUG' for more details.");
                     $show_warning := 0;
             }
+            =end comment
         }
 
         sub normalize_vis_col_sep_rows(@Rows) {