Reimplement Hash.classify/categorize using nqp primitives

This makes for about a 40% reduction in CPU
rakudo · Jul 29, 2013 · 5628e68 · 5628e68
1 parent 72b1b02
commit 5628e68
Showing 1 changed file with 15 additions and 21 deletions.
diff --git a/src/core/Hash.pm b/src/core/Hash.pm
@@ -108,51 +108,45 @@ my class Hash {
     proto method classify(|) { * }
     multi method classify( &test, *@list ) {
         fail 'Cannot .classify an infinite list' if @list.infinite;
-        for @list {
+        nqp::push( nqp::p6listitems(nqp::decont(self{test $_} //= [])), $_ )
-            self{test $_}.push: $_;
+          for @list;
-        }
         self;
     }
     multi method classify( %test, *@list ) {
         fail 'Cannot .classify an infinite list' if @list.infinite;
-        for @list {
+        nqp::push( nqp::p6listitems(nqp::decont(self{%test{$_}} //= [])), $_ )
-            self{ %test{$_} }.push: $_;
+          for @list;
-        }
         self;
     }
     multi method classify( @test, *@list ) {
         fail 'Cannot .classify an infinite list' if @list.infinite;
-        for @list {
+        nqp::push( nqp::p6listitems(nqp::decont(self{@test[$_]} //= [])), $_ )
-            self{ @test[$_] }.push: $_;
+          for @list;
-        }
         self;
     }
 
     proto method categorize(|) { * }
     multi method categorize( &test, *@list ) {
         fail 'Cannot .categorize an infinite list' if @list.infinite;
-        for @list {
+        for @list -> $l {
-            for test($_) -> $k {
+            nqp::push( nqp::p6listitems(nqp::decont(self{$_} //= [])), $l )
-                self{$k}.push: $_;
+              for test($l);
-            }
         }
         self;
     }
     multi method categorize( %test, *@list ) {
         fail 'Cannot .categorize an infinite list' if @list.infinite;
-        for @list {
+        for @list -> $l {
-            for %test{$_} -> $k {
+            nqp::push( nqp::p6listitems(nqp::decont(self{$_} //= [])), $l )
-                self{$k}.push: $_;
+              for %test{$l};
-            }
         }
         self;
     }
     multi method categorize( @test, *@list ) {
         fail 'Cannot .categorize an infinite list' if @list.infinite;
-        for @list {
+        for @list -> $l {
-            for @test[$_] -> $k {
+            nqp::push( nqp::p6listitems(nqp::decont(self{$_} //= [])), $l )
-                self{$k}.push: $_;
+              for @test[$l];
-            }
         }
         self;
     }