Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[create-jvm-runner.pl] die more
Fail early, fail often. The two sites where I added 'die' statements were
the ones where I would have liked for it to die with informative error
messages instead of just continuing.
  • Loading branch information
Carl Masak committed Jun 21, 2013
1 parent b5c9c7b commit 85f7372
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tools/build/create-jvm-runner.pl
Expand Up @@ -7,7 +7,10 @@
use File::Spec;
use File::Copy 'cp';

my ($prefix, $nqpprefix, $thirdpartyjars) = @ARGV;
my $USAGE = "Usage: $0 <prefix> <nqp prefix> <third party jars>\n";

my ($prefix, $nqpprefix, $thirdpartyjars) = @ARGV
or die $USAGE;

This comment has been minimized.

Copy link
@KamilaBorowska

KamilaBorowska Jun 29, 2013

This will only make $prefix mandatory from what I see.


my $cpsep = $^O eq 'MSWin32' ? ';' : ':';
my $bat = $^O eq 'MSWin32' ? '.bat' : '';
Expand All @@ -33,4 +36,5 @@ sub install {
install "perl6", "java $jopts perl6";
install "perl6-jdb-server", "java -Xdebug -Xrunjdwp:transport=dt_socket,address=8000,server=y,suspend=n $jopts perl6";
install "perl6-eval-server", "java $jopts org.perl6.nqp.runtime.EvalServer TESTTOKEN " . File::Spec->catfile($prefix,"perl6.class");
cp(File::Spec->catfile($nqpprefix,"eval-client.pl"), ".");
cp(File::Spec->catfile($nqpprefix,"eval-client.pl"), ".")
or die "Couldn't copy 'eval-client.pl' into $nqpprefix: $!";

0 comments on commit 85f7372

Please sign in to comment.