Minor optimizations in List/Array.

rakudo · Jul 25, 2013 · cc9cf16 · cc9cf16
1 parent f173b55
commit cc9cf16
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/core/Array.pm b/src/core/Array.pm
@@ -89,8 +89,9 @@ class Array {
         nqp::findmethod(List, 'REIFY')(self, parcel, nextiter)
     }
 
-    method STORE_AT_POS(\pos, Mu $v is copy) is rw {
-        nqp::findmethod(List, 'STORE_AT_POS')(self, pos, $v);
+    method STORE_AT_POS(Int \pos, Mu $v is copy) is rw {
+        nqp::bindpos(nqp::getattr(self, List, '$!items'),
+            nqp::unbox_i(pos), $v)
     }
 
     method STORE(|) {

diff --git a/src/core/List.pm b/src/core/List.pm
@@ -182,9 +182,9 @@ my class List does Positional {
     }
 
     multi method push(List:D: *@values) {
-        fail 'Cannot .push to an infinite list' if self.infinite; #MMD?
         fail 'Cannot .push an infinite list' if @values.infinite;
-        my $pos = self.elems;
+        my $pos = self.gimme(*);
+        fail 'Cannot .push an infinite list' if $!nextiter.defined;
         self.STORE_AT_POS($pos++, @values.shift) while @values.gimme(1);
         self;
     }
@@ -370,7 +370,7 @@ my class List does Positional {
         parcel
     }
 
-    method STORE_AT_POS(\pos, Mu \v) is rw {
+    method STORE_AT_POS(Int \pos, Mu \v) is rw {
         nqp::bindpos($!items, nqp::unbox_i(pos), v)
     }