Remove src/core/UInt64.pm

This appears to be a leftover from at about 7 years ago. It created a subset that was not being used anywhere and a constant that was needed for Rat/FatRat. UInt64 (not to be confused with uint64) is not documented anywhere and not tested. Moved the constant to src/core/Rat and changed it into a real constant. Kudos to Andrew Shitov for spotting this: https://perl6.online/2018/01/15/26-native-integers-and-uint-in-perl-6/
rakudo · Jan 16, 2018 · cf15435 · cf15435
1 parent 64803b0
commit cf15435
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/src/core/Rat.pm b/src/core/Rat.pm
@@ -23,10 +23,12 @@ my class Rat is Cool does Rational[Int, Int] {
     }
 }
 
+my constant UINT64_UPPER = nqp::pow_I(2, 64, Num, Int);
+
 my class FatRat is Cool does Rational[Int, Int] {
     method FatRat(FatRat:D: Real $?) { self }
     method Rat   (FatRat:D: Real $?) {
-        $!denominator < $UINT64_UPPER
+        $!denominator < UINT64_UPPER
           ?? Rat.new($!numerator, $!denominator)
           !! Failure.new("Cannot convert from FatRat to Rat because denominator is too big")
     }
@@ -51,7 +53,7 @@ sub DIVIDE_NUMBERS(Int:D \nu, Int:D \de, \t1, \t2) {
           nqp::p6bindattrinvres(nqp::create(FatRat),FatRat,'$!numerator',$numerator),
           FatRat,'$!denominator',$denominator),
         nqp::if(
-          $denominator < $UINT64_UPPER,
+          $denominator < UINT64_UPPER,
           nqp::p6bindattrinvres(
             nqp::p6bindattrinvres(nqp::create(Rat),Rat,'$!numerator',$numerator),
             Rat,'$!denominator',$denominator),

diff --git a/src/core/UInt64.pm b/src/core/UInt64.pm
diff --git a/tools/build/jvm_core_sources b/tools/build/jvm_core_sources
@@ -40,7 +40,6 @@ src/core/Real.pm
 src/core/Int.pm
 src/core/Bool.pm
 src/core/Order.pm
-src/core/UInt64.pm
 src/core/Num.pm
 src/core/Buf.pm
 src/core/Encoding/Decoder.pm

diff --git a/tools/build/moar_core_sources b/tools/build/moar_core_sources
@@ -40,7 +40,6 @@ src/core/Real.pm
 src/core/Int.pm
 src/core/Bool.pm
 src/core/Order.pm
-src/core/UInt64.pm
 src/core/Num.pm
 src/core/Buf.pm
 src/core/Uni.pm