Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is DEPRECATED doesn't work on Routines in precomped modules #1219

Closed
lizmat opened this issue Oct 28, 2017 · 3 comments
Closed

is DEPRECATED doesn't work on Routines in precomped modules #1219

lizmat opened this issue Oct 28, 2017 · 3 comments
Labels
tests needed Issue is generally resolved but tests were not written yet

Comments

@lizmat
Copy link
Contributor

lizmat commented Oct 28, 2017 •
edited by AlexDaniel

Foo.pm:

class A {
    method a() is DEPRECATED<b> {
    }
}

$ perl6 --ll-exception -I. -MFoo -e 'dd A.a'
Cannot invoke this object (REPR: Null; VMNull)
   at SETTING::src/core/traits.pm:150  (/Users/liz/Github/rakudo.moar/install/share/perl6/runtime/CORE.setting.moarvm:)
 from /Users/liz/Github/rakudo.moar/Foo.pm6 (Foo):3  (/Users/liz/Github/rakudo.moar/.precomp/E7148DC9FED15B480AF079994892987152D023CD.1509221700.44536/20/201A6B3053CC1422D2C3670B62616221D2290929:a)
 from -e:1  (<ephemeral file>:<unit>)
 from -e:1  (<ephemeral file>:<unit-outer>)
@zoffixznet zoffixznet assigned zoffixznet and unassigned zoffixznet Oct 28, 2017
@skids
Copy link
Contributor

skids commented May 23, 2018

Workaround PRd in #1861

lizmat added a commit that referenced this issue May 24, 2018
@lizmat
Look up DEPRECATED at the *end* of compilation
472f6e4 
Since traits.pm6 is about the first file in settings being compiled,
it did not know about &DEPRECATED yet.  And somehow it is being forgotten
so the precomp got a VMnull there.  Mitigated by having the coderef for
&DEPRECATED looked up at end of setting compilation by using CHECK.

Finally fixes R #1219 .  skids++ for the nudge to get me looking at this
again.
@lizmat
Copy link
Contributor Author

lizmat commented May 24, 2018

Fixed with 472f6e4

@lizmat lizmat added the tests needed Issue is generally resolved but tests were not written yet label May 24, 2018
@bbkr bbkr mentioned this issue Jun 3, 2018
Closed
lukasvalle added a commit to lukasvalle/roast that referenced this issue Jun 2, 2019
@lukasvalle
Test for rakudo/rakudo#1219
bd78c46
@lukasvalle lukasvalle mentioned this issue Jun 2, 2019
Merged
lizmat added a commit to Raku/roast that referenced this issue Jun 2, 2019
@lizmat
Merge pull request #546 from lukasvalle/master
827385b 
Test for rakudo/rakudo#1219
@vrurg
Copy link
Member

vrurg commented Aug 26, 2020

Looks like merge Raku/roast#546 closed this ticket.

@vrurg vrurg closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests needed Issue is generally resolved but tests were not written yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@skids @vrurg @lizmat @zoffixznet