Toaster results show several modules' tests rely on buggy Num stringification

[zoffixznet]

Filing in hopes of getting more helping hands on this.

There are several modules on https://toaster.perl6.party/ at the top, with "Fail" in the right column. If you click on "Fail" you'll see test results. And in a bunch of modules, you'll see they test a specific stringification of a Num.

Presumably, they're testing a num using is routine, when they should be using is-approx routine or, if the nums are actually meant to be exactly equal, with cmp ...,'==', ... routine.

So we need volunteers to PR fixes to those modules' tests, swapping to correct testing functions or fixing the failures by some other means.

If you send a PR, please comment on this issue the name of the module, so others would know it's fixed already.

[sylints]

Changed tests on Stats module, which should resolve the failure in the BioInfo module as well.

[sylints]

Changed tests in ScaleVec module, which should also resolve the failure in Music::Engine

[AlexDaniel]

Thank you, @sylints!

[AlexDaniel]

Not a blocker per se, but we try to fix issues in the ecosystem before the release.

[AlexDaniel]

I did my own toaster run today, and here are the results:

	Module	Note
✓	Algorithm::GooglePolylineEncoding	Scimon/p6-Algorithm-GooglePolylineEncoding#1
👪	BioInfo	depends on Stats
👪	CSS::Declarations	depends on CSS::Specification
👪	CSS::Module	depends on CSS::Specification
🐦	CSS::Specification	toaster flop, installs fine locally
☠	Chemistry::Elements	rakudobug #1753
🐦	DB::Model::Easy	toaster flop, installs fine locally
👪	Music::Engine	depends on ScaleVec
✓	Ops::SI	scriptkitties/perl6-Ops-SI#2
✓	Perl6-Math-Quaternion	Util/Perl6-Math-Quaternion#7
✓	ScaleVec	samgwise/p6-ScaleVec#1 (@sylints++)
✓	Stats	MattOates/Stats#7 (@sylints++)
🐦	ANTLR4::Grammar	toaster flop, installs fine locally
🐦	Cro::HTTP::Session::Redis	toaster flop, installs fine locally
🐦	Number::Denominate	toaster flop, installs fine locally

Those marked with ✓ had an issue described in this ticket and were fixed.