Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RESOLVED; NEED TEST] &round inconsistent on types of arguments. #1745

Closed
zoffixznet opened this issue Apr 18, 2018 · 0 comments
Closed

[RESOLVED; NEED TEST] &round inconsistent on types of arguments. #1745

zoffixznet opened this issue Apr 18, 2018 · 0 comments
Labels
consistency easy to resolve This issue is likely easy for beginners to resolve good first issue This issue is likely easy for beginners to resolve tests needed Issue is generally resolved but tests were not written yet

Comments

@zoffixznet
Copy link
Contributor

Single-arg form accepts a Cool while multi-arg form requires a Numeric:

19:31 	Zoffix 	It is a bit LTA that you can give a Cool in single-arg form, but you gotta give a Numeric in 2-arg form
		2 more elements. Show/hide.
19:31 	Zoffix 	m: say round <a b c>
19:31 	camelia 	rakudo-moar 9e6ae276a: OUTPUT: «3␤»
19:31 	Zoffix 	m: say round <a b c>, 10
19:31 	camelia 	rakudo-moar 9e6ae276a: OUTPUT: «Cannot resolve caller round(List, Int); none of these signatures match:␤    ($a)␤    (Numeric $a)␤    (Numeric $a, $scale)␤  in block <unit> at <tmp> line 1␤␤»
@zoffixznet zoffixznet added good first issue This issue is likely easy for beginners to resolve consistency labels Apr 18, 2018
@zoffixznet zoffixznet added the easy to resolve This issue is likely easy for beginners to resolve label May 14, 2018
@jkramer jkramer mentioned this issue Jul 4, 2018
Merged
@zoffixznet zoffixznet added the tests needed Issue is generally resolved but tests were not written yet label Jul 4, 2018
@zoffixznet zoffixznet reopened this Jul 4, 2018
@zoffixznet zoffixznet changed the title &round inconsistent on types of arguments. [RESOLVED; NEED TEST] &round inconsistent on types of arguments. Jul 4, 2018
@jkramer jkramer mentioned this issue Jul 4, 2018
Merged
zoffixznet added a commit to Raku/roast that referenced this issue Jul 4, 2018
@zoffixznet
Merge pull request #444 from jkramer/rakudo-1745
1e17e66 
Tests for rakudo/rakudo#1745.
ugexe pushed a commit to Raku/roast that referenced this issue Dec 15, 2018
@jkramer @ugexe
Add tests for rakudo/rakudo#1745 plus some more for 2-argument versio…
50e5d55 
…n of &round.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consistency easy to resolve This issue is likely easy for beginners to resolve good first issue This issue is likely easy for beginners to resolve tests needed Issue is generally resolved but tests were not written yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zoffixznet