Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: remove kludge in Str.perl after null str bug is resolved #1837

Open
zoffixznet opened this issue May 17, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@zoffixznet
Copy link
Contributor

commented May 17, 2018

b12fba3 adds a kludge to bail out if a string is null, however, the code shown in the commit message likely shouldn't have null strings in the first place as they cause issues in many other places:

m: -> Str $x { use nqp; dd $x ~ "" }((my str @)[1])
rakudo-moar 8ccda1890: OUTPUT: «concatenate requires a concrete string, but got null␤  in block <unit> at <tmp> line 1␤␤»

There's a possibly-incorrect PR in MoarVM to fix this bug: MoarVM/MoarVM#767

When the bug is fixed, the kludge should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.