Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad codegen with ,= meta op #1890

Closed
zoffixznet opened this issue May 31, 2018 · 1 comment · Fixed by Raku/roast#749
Closed

Bad codegen with ,= meta op #1890

zoffixznet opened this issue May 31, 2018 · 1 comment · Fixed by Raku/roast#749
Labels
codegen tests needed Issue is generally resolved but tests were not written yet

Comments

@zoffixznet
Copy link
Contributor

zoffixznet commented May 31, 2018

Looks like some cases gen assign instead of p6store op, which causes errors to be thrown:

https://irclog.perlgeek.de/perl6/2018-05-31#i_16229415

14:48 	Zoffix 	m: say [] ,= 42
14:48 	camelia 	rakudo-moar c80ea2f28: OUTPUT: «Cannot assign to an immutable value␤  in block <unit> at <tmp> line 1␤␤»
14:48 	Zoffix 	What immutable value?
14:49 	moritz 	m: [] = 42
14:49 	camelia 	rakudo-moar c80ea2f28: ( no output )
14:50 	moritz 	m: [] = [], 42
14:50 	camelia 	rakudo-moar c80ea2f28: ( no output )
14:50 	moritz 	looks like a bug to me


14:50 	Zoffix 	Yeah, looks like the genned QAST uses assign instead p6store op



14:51 		m: my @a; my @b; @a ,= @b
14:51 	camelia 	rakudo-moar c80ea2f28: ( no output )
14:51 	Zoffix 	m: my @a; my @b; @a [R,]= @b
14:51 	camelia 	rakudo-moar c80ea2f28: OUTPUT: «Cannot assign to an immutable value␤  in block <unit> at <tmp> line 1␤␤»
@dogbert17
Copy link

As per b9b0838 it no longer crashes. Fixed?

@Altai-man Altai-man added the tests needed Issue is generally resolved but tests were not written yet label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen tests needed Issue is generally resolved but tests were not written yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants