New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANTLR4::Grammar tests fail unless MVM_SPESH_INLINE_DISABLE=1 #2046

Closed
AlexDaniel opened this Issue Jul 11, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@AlexDaniel
Member

AlexDaniel commented Jul 11, 2018

No golf or bisect result yet, just stubbing a ticket.

See https://github.com/drforr/perl6-ANTLR4.

When running tests:

PERL6LIB=lib/ perl6 --ll-exception t/03-corpus-compile.t
1..48
Invocant of method 'match' must be a type object of type 'Any', not an object instance of type 'Concatenation'.  Did you forget a 'multi'?
   at SETTING::src/core/Exception.pm6:57  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:throw)
 from SETTING::src/core/Exception.pm6:2752  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:)
 from gen/moar/BOOTSTRAP.nqp:352  (/home/alex/.rakudobrew/moar-master/install/share/nqp/lib/Perl6/BOOTSTRAP.moarvm:)
 from gen/moar/BOOTSTRAP.nqp:3701  (/home/alex/.rakudobrew/moar-master/install/share/nqp/lib/Perl6/BOOTSTRAP.moarvm:)
 from SETTING::src/core/Any.pm6:130  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:match)
 from SETTING::src/core/Regex.pm6:88  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:Bool)
 from SETTING::src/core/Mu.pm6:101  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:Bool)
 from SETTING::src/core/Any-iterable-methods.pm6:347  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:pull-one)
 from SETTING::src/core/Any-iterable-methods.pm6:415  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:push-all)
 from SETTING::src/core/Iterator.pm6:69  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:push-until-lazy)
 from SETTING::src/core/Array.pm6:268  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:STORE)
 from /home/alex/git/perl6-ANTLR4/lib/ANTLR4/Grammar.pm6 (ANTLR4::Grammar):165  (/home/alex/git/perl6-ANTLR4/lib/.precomp/DDBB58D2B62EFE4E6B1B52903ADDE6D931E54FFF/29/293CE3F93C6A964B31CACAC266DE6631628D8DC1:)
 from /home/alex/git/perl6-ANTLR4/lib/ANTLR4/Grammar.pm6 (ANTLR4::Grammar):162  (/home/alex/git/perl6-ANTLR4/lib/.precomp/DDBB58D2B62EFE4E6B1B52903ADDE6D931E54FFF/29/293CE3F93C6A964B31CACAC266DE6631628D8DC1:to-lines)
 from /home/alex/git/perl6-ANTLR4/lib/ANTLR4/Grammar.pm6 (ANTLR4::Grammar):177  (/home/alex/git/perl6-ANTLR4/lib/.precomp/DDBB58D2B62EFE4E6B1B52903ADDE6D931E54FFF/29/293CE3F93C6A964B31CACAC266DE6631628D8DC1:)
 from /home/alex/git/perl6-ANTLR4/lib/ANTLR4/Grammar.pm6 (ANTLR4::Grammar):176  (/home/alex/git/perl6-ANTLR4/lib/.precomp/DDBB58D2B62EFE4E6B1B52903ADDE6D931E54FFF/29/293CE3F93C6A964B31CACAC266DE6631628D8DC1:to-lines)
 from /home/alex/git/perl6-ANTLR4/lib/ANTLR4/Grammar.pm6 (ANTLR4::Grammar):193  (/home/alex/git/perl6-ANTLR4/lib/.precomp/DDBB58D2B62EFE4E6B1B52903ADDE6D931E54FFF/29/293CE3F93C6A964B31CACAC266DE6631628D8DC1:)
 from /home/alex/git/perl6-ANTLR4/lib/ANTLR4/Grammar.pm6 (ANTLR4::Grammar):193  (/home/alex/git/perl6-ANTLR4/lib/.precomp/DDBB58D2B62EFE4E6B1B52903ADDE6D931E54FFF/29/293CE3F93C6A964B31CACAC266DE6631628D8DC1:to-lines)
 from SETTING::src/core/stubs.pm6:64  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/CORE.setting.moarvm:AUTOGEN)
 from /home/alex/git/perl6-ANTLR4/lib/ANTLR4/Grammar.pm6 (ANTLR4::Grammar):226  (/home/alex/git/perl6-ANTLR4/lib/.precomp/DDBB58D2B62EFE4E6B1B52903ADDE6D931E54FFF/29/293CE3F93C6A964B31CACAC266DE6631628D8DC1:file-to-string)
 from t/03-corpus-compile.t:7  (<ephemeral file>:compile)
 from t/03-corpus-compile.t:20  (<ephemeral file>:<unit>)
 from t/03-corpus-compile.t:1  (<ephemeral file>:<unit-outer>)
 from gen/moar/stage2/NQPHLL.nqp:1566  (/home/alex/.rakudobrew/moar-master/install/share/nqp/lib/NQPHLL.moarvm:eval)
 from gen/moar/stage2/NQPHLL.nqp:1805  (/home/alex/.rakudobrew/moar-master/install/share/nqp/lib/NQPHLL.moarvm:evalfiles)
 from gen/moar/stage2/NQPHLL.nqp:1728  (/home/alex/.rakudobrew/moar-master/install/share/nqp/lib/NQPHLL.moarvm:command_eval)
 from src/Perl6/Compiler.nqp:42  (/home/alex/.rakudobrew/moar-master/install/share/nqp/lib/Perl6/Compiler.moarvm:command_eval)
 from gen/moar/stage2/NQPHLL.nqp:1654  (/home/alex/.rakudobrew/moar-master/install/share/nqp/lib/NQPHLL.moarvm:command_line)
 from gen/moar/main.nqp:47  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/perl6.moarvm:MAIN)
 from gen/moar/main.nqp:38  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/perl6.moarvm:<mainline>)
 from <unknown>:1  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/perl6.moarvm:<main>)
 from <unknown>:1  (/home/alex/.rakudobrew/moar-master/install/share/perl6/runtime/perl6.moarvm:<entry>)

But it works fine with MVM_SPESH_DISABLE=1.

@jnthn jnthn changed the title from ANTLR4::Grammar tests fail unless MVM_SPESH_DISABLE=1 to ANTLR4::Grammar tests fail unless MVM_SPESH_INLINE_DISABLE=1 Jul 16, 2018

@jnthn

This comment has been minimized.

Show comment
Hide comment
@jnthn

jnthn Jul 19, 2018

Member

Same underlying cause as #2058; see this comment on resolution. Tested this module and it now passes its tests again.

Member

jnthn commented Jul 19, 2018

Same underlying cause as #2058; see this comment on resolution. Tested this module and it now passes its tests again.

@AlexDaniel

This comment has been minimized.

Show comment
Hide comment
@AlexDaniel

AlexDaniel Jul 19, 2018

Member

Yeah, looks good!

Member

AlexDaniel commented Jul 19, 2018

Yeah, looks good!

@lizmat

This comment has been minimized.

Show comment
Hide comment
@lizmat

lizmat Jul 26, 2018

Contributor

Not sure how a test can be devised for this that isn't already covered by #2058 tests. So closing this ticket now. Please re-open if you disagree.

Contributor

lizmat commented Jul 26, 2018

Not sure how a test can be devised for this that isn't already covered by #2058 tests. So closing this ticket now. Please re-open if you disagree.

@lizmat lizmat closed this Jul 26, 2018

@lizmat lizmat removed the testneeded label Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment