Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode::GCB failing tests after “Bump NQP to get unicode 11” #2399

Closed
AlexDaniel opened this Issue Oct 19, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@AlexDaniel
Copy link
Member

AlexDaniel commented Oct 19, 2018

Unicode::GCB – Fail, Bisected: acd8325

This is likely not a bug in rakudo, but it should be investigated and a PR to the module should be sent.

===> Testing: Unicode::GCB:ver<0.2.1>:auth<github:cygx>
# Failed test at t/01-sanity.t line 14
# Failed test at t/01-sanity.t line 15
# Looks like you failed 2 tests of 4
t/01-sanity.t .. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/4 subtests 

Test Summary Report
-------------------
t/01-sanity.t (Wstat: 512 Tests: 4 Failed: 2)
  Failed tests:  2-3
  Non-zero exit status: 2
Files=1, Tests=4,  5 wallclock secs ( 0.03 usr  0.00 sys +  2.68 cusr  0.12 csys =  2.83 CPU)
Result: FAIL
@AlexDaniel

This comment has been minimized.

Copy link
Member Author

AlexDaniel commented Oct 20, 2018

Further discussion here: cygx/p6-unicode-gcb#1

Keeping it open for a bit until it is resolved.

@cygx

This comment has been minimized.

Copy link
Contributor

cygx commented Oct 20, 2018

I'll look into it. As far as I'm concerned, I wouldn't necessarily consider this a blocker (the use nqp disclaimer applies).

However, this does raise the following question: How should incompatible changes to Unicode be handled in the future?

Should MoarVM ship with several versions of the unicode database, and have a mechanism for users to decide which one to use? Or do we accept that code relying on advanced unicode features might break occasionally, even when the Perl6 language version stays the same?

@AlexDaniel

This comment has been minimized.

Copy link
Member Author

AlexDaniel commented Oct 20, 2018

@cygx See #2031 for a very related issue.

@AlexDaniel

This comment has been minimized.

Copy link
Member Author

AlexDaniel commented Oct 21, 2018

@AlexDaniel AlexDaniel closed this Oct 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.