t/05-messages/02-errors.t crashes

[zoffixznet]

The t/05-messages/02-errors.t test file in Rakudo's test suite started failing after merging #2344 and its related Raku/nqp#505 and MoarVM/MoarVM#980

The test in question is:

throws-like {
    sub l { IO::Socket::Async.listen: "localhost", 111390 }
    react whenever l() {
        whenever l() {} # try to listen on already open sock
    }
}, X::AdHoc, message => /'something good'/;

It fails with this message:

cpan@perlbuild4~/R/rakudo (master)$ z t t/05-messages/02-errors.t
t/05-messages/02-errors.t .. 
1..37
    1..3
    ok 1 - STDOUT
    ok 2 - STDERR
    ok 3 - Exit code
ok 1 - :2(1) suggests using 1.base(2)
    1..3
    ok 1 - code dies
    ok 2 - right exception type (Exception)
    ok 3 - .message matches / '<anon>' /
ok 2 - anonymous subs get '<anon>' in arity error messages
    1..3
    not ok 1 - code dies # TODO needs better error message
Unhandled exception in code scheduled on thread 4
    # Failed test 'code dies'
    # at t/05-messages/02-errors.t line 20
    ok 2 - # SKIP Code did not die, can not check exception
    ok 3 - # SKIP Code did not die, can not check exception
not ok 3 - did we throws-like X::AdHoc? # TODO needs better error message
# Failed test 'did we throws-like X::AdHoc?'
# at t/05-messages/02-errors.t line 20
ok 4 - auto-generated methods present in .^methods
Access denied to keep/break this Promise; already vowed
# Looks like you planned 37 tests, but ran 4
Dubious, test returned 1 (wstat 256, 0x100)
Failed 33/37 subtests 
Test Summary Report
-------------------
t/05-messages/02-errors.t (Wstat: 256 Tests: 4 Failed: 0)
  Non-zero exit status: 1
  Parse errors: Bad plan.  You planned 37 tests but ran 4.
Files=1, Tests=4,  1 wallclock secs ( 0.02 usr  0.02 sys +  1.23 cusr  0.11 csys =  1.38 CPU)
Result: FAIL
The spawned command 't/fudgeandrun' exited unsuccessfully (exit code: 1)
  in block <unit> at /home/cpan/zscript/bin/z line 154
cpan@perlbuild4~/R/rakudo (master)$

I fudged it in