Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date/DateTime regression (expected Int:D but got Int (Int)) #2615

Closed
AlexDaniel opened this Issue Jan 17, 2019 · 7 comments

Comments

Projects
None yet
2 participants
@AlexDaniel
Copy link
Member

AlexDaniel commented Jan 17, 2019

t/02-Workdate_basic.t ......... 
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 6/18 subtests 
# Testing the creation of a Workdate from a Date
# Testing Date and Workdate operators
Type check failed for return value; expected Int:D but got Int (Int)
  in block <unit> at t/03-Workdate_Date.t line 27

Bisected: 9f28a42

See https://github.com/perl6-community-modules/Date-WorkdayCalendar

🥞

@AlexDaniel

This comment has been minimized.

Copy link
Member Author

AlexDaniel commented Jan 17, 2019

Another module that bisects to the same commit and has similar error messages:
https://github.com/zoffixznet/perl6-Games-TauStation-DateTime

@lizmat lizmat self-assigned this Jan 17, 2019

@lizmat

This comment has been minimized.

Copy link
Contributor

lizmat commented Jan 18, 2019

spectesting a fix

@lizmat

This comment has been minimized.

Copy link
Contributor

lizmat commented Jan 18, 2019

Fixed with 9295616

@lizmat lizmat added tests needed and removed BLOCKER labels Jan 18, 2019

@lizmat

This comment has been minimized.

Copy link
Contributor

lizmat commented Jan 18, 2019

Added tests with perl6/roast@529b04d

@lizmat lizmat closed this Jan 18, 2019

@AlexDaniel AlexDaniel added BLOCKER and removed tests needed labels Jan 24, 2019

@AlexDaniel

This comment has been minimized.

Copy link
Member Author

AlexDaniel commented Jan 24, 2019

@AlexDaniel AlexDaniel reopened this Jan 24, 2019

@AlexDaniel AlexDaniel changed the title Weird issue with Date creation and Date::WorkdayCalendar module Date/DateTime regression (expected Int:D but got Int (Int)) Jan 24, 2019

@AlexDaniel

This comment has been minimized.

Copy link
Member Author

AlexDaniel commented Jan 24, 2019

@lizmat also, TauStation still fails (mentioned in the second comment). So currently two modules need to be looked at.

@AlexDaniel AlexDaniel referenced this issue Jan 24, 2019

Closed

[WIP] Blin 2019.01 #2638

13 of 13 tasks complete
@lizmat

This comment has been minimized.

Copy link
Contributor

lizmat commented Jan 24, 2019

Fixed with 3488a65, tests added with perl6/roast@9d55fd0

@lizmat lizmat closed this Jan 24, 2019

@lizmat lizmat removed the BLOCKER label Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.