Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something going on in Data::StaticTable #2643

Open
AlexDaniel opened this Issue Jan 25, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@AlexDaniel
Copy link
Member

AlexDaniel commented Jan 25, 2019

There's something going on with Data::StaticTable but I don't know what exactly yet. Basically, some of the test files are known to flap, but on HEAD it's consistently bad. For example, t/StaticTable-examples.t is now failing even though previously it didn't (I think…).

Not bisected, and no golf of the issue. Feel free to dive in.

@AlexDaniel AlexDaniel added the BLOCKER label Jan 25, 2019

@AlexDaniel AlexDaniel changed the title Data::StaticTable Something going on in Data::StaticTable Jan 25, 2019

@AlexDaniel AlexDaniel referenced this issue Jan 25, 2019

Closed

[WIP] Blin 2019.01 #2638

13 of 13 tasks complete
@lizmat

This comment has been minimized.

Copy link
Contributor

lizmat commented Jan 26, 2019

This appears to be related to the use of rx/foo/ as a "matcher" parameter to a custom grep method, which in turn uses grep with $_ and the "matcher" parameter that assumes it can match with $_:

I'm not sure if this is supposed to work like this or not. Perhaps @jnthn knows / can decide.

@jnthn

This comment has been minimized.

Copy link
Member

jnthn commented Jan 28, 2019

I'm not sure if this is supposed to work like this or not. Perhaps @jnthn knows / can decide.

Under 6.c semantics, yes; under 6.d ones, including with the proposed refinement in #2608, no.

@jnthn

This comment has been minimized.

Copy link
Member

jnthn commented Jan 28, 2019

Um, to be clear, that could work with 6.c semantics, but not the 6.d ones.

@AlexDaniel

This comment has been minimized.

Copy link
Member Author

AlexDaniel commented Jan 29, 2019

I submitted a PR here: shinobi/Data-StaticTable#5

However, the label remains for now. See https://colabti.org/irclogger/irclogger_log/perl6-dev?date=2019-01-29#l74

jnthn added a commit that referenced this issue Jan 29, 2019

Further fix grep with regex returns
A fix was applied, but did not cover the case where we had adverbs.
Additionally, fix the case where we have a Junction of Regex being
returned from the `grep` block. This fixes the regressions reported
in #2643.
@AlexDaniel

This comment has been minimized.

Copy link
Member Author

AlexDaniel commented Jan 31, 2019

Ah, this one is fixed, as far as I can see. Some tests are needed, I think, but otherwise everything is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.