You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
my class X::Syntax::Comment::Embedded does X::Syntax {
method message() { "Opening bracket required for #` comment" }
}
the perl6/doc styleguide requires that we use "curly brace" here instead of bracket, and we have a currently failing test:
$ xt/braces.t doc/Type/X/Syntax/Comment/Embedded.pod6
1..1
not ok 1 - doc/Type/X/Syntax/Comment/Embedded.pod6: Found 'bracket' without 'square' or 'angle'.
# Failed test 'doc/Type/X/Syntax/Comment/Embedded.pod6: Found 'bracket' without 'square' or 'angle'.'
# at xt/braces.t line 37
# Looks like you failed 1 test of 1
While not a must have, I think following the doc style guide for this exception is correct (and then we can update the text in the doc site and then pass the test)
The text was updated successfully, but these errors were encountered:
coke
changed the title
Error message doesn't follow doc style guide
Exception message doesn't follow doc style guide
Feb 4, 2019
OK, first of all, I'm unable to trigger that message.
Secondly, the proposed change is incorrect here. In the doc repo, curly brace is used to refer to {. However, this error message talks about any opening bracket that is supported by #` (through unicode). It can be changed to something more generic (like opener or something better).
The Problem
the perl6/doc styleguide requires that we use "curly brace" here instead of bracket, and we have a currently failing test:
While not a must have, I think following the doc style guide for this exception is correct (and then we can update the text in the doc site and then pass the test)
The text was updated successfully, but these errors were encountered: