Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypt::TweetNacl test suite fails since 762c708fdcef #2681

Closed
soundart opened this issue Feb 8, 2019 · 11 comments
Closed

Crypt::TweetNacl test suite fails since 762c708fdcef #2681

soundart opened this issue Feb 8, 2019 · 11 comments
Assignees
Labels
regression Issue did not exist previously tests needed Issue is generally resolved but tests were not written yet

Comments

@soundart
Copy link

soundart commented Feb 8, 2019

The Problem

Crypt::TweetNacl test suite fails:
see https://travis-ci.org/soundart/perl6-tweetnacl/jobs/393657936
Raku/ecosystem-unbitrot#368

AlexDaniel bisected this:

(01:25:19 PM) AlexDaniel: frankjh: 🥞🥞🥞 Bisecting Crypt::TweetNacl
(01:25:42 PM) AlexDaniel: frankjh: we'll see the result soon, but I guess you're right that it's a regression of some sort
(01:26:03 PM) AlexDaniel: frankjh: I confirm that on 2018.05 it passes OK
(01:27:14 PM) frankjh: AlexDaniel: travis uses now his is Rakudo version 2018.12-288-g5be7555fd built on MoarVM version 2018.12-45-ga9d02578aimplementing Perl 6.d. and it falis there too
(01:27:34 PM) AlexDaniel: frankjh: yeah… I wonder how we managed to miss that
(01:34:22 PM) AlexDaniel: frankjh: ok, it was bisected to this commit: 762c708

Expected Behavior

pass

Actual Behavior

t/01-basic.t .............. 
1..5
ok 1 - The object is-a 'NativeCall::Types::CArray[int8]'
ok 2 - The object is-a 'NativeCall::Types::CArray[int8]'
ok 3 - 
ok 4 - 
Cannot resolve caller STORE(Buf:D: NativeCall::Types::CArray[uint8]:D, :INITIALIZE); none of these signatures match:
    (Buf:D: Blob:D $blob, *%_)
    (Buf:D: int @values, *%_)
    (Buf:D: Iterable:D \iterable, *%_)
    (Blob:D: Iterable:D \iterable, :$INITIALIZE, *%_)
  in submethod BUILD at /home/travis/build/soundart/perl6-tweetnacl/lib/Crypt/TweetNacl/Basics.pm6 (Crypt::TweetNacl::Basics) line 35
  in block <unit> at t/01-basic.t line 17
# Looks like you planned 5 tests, but ran 4
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/5 subtests 

Steps to Reproduce

Environment

  • Operating system:
  • Compiler version (perl6 -v):
@AlexDaniel AlexDaniel added the BLOCKER Preventing the next release of rakudo, or just needing attention before the release label Feb 8, 2019
@AlexDaniel AlexDaniel changed the title Crypt::TweetNacl test suite fails since 762c708fdcef3e52f49800ba9a621d29449e82fa Crypt::TweetNacl test suite fails since 762c708fdcef Feb 8, 2019
@AlexDaniel AlexDaniel added the regression Issue did not exist previously label Feb 8, 2019
@AlexDaniel
Copy link
Contributor

AlexDaniel commented Feb 8, 2019

Ping @lizmat (bisected 762c708)

soundart referenced this issue Feb 8, 2019
The Buf/Blob roles did not directly support the .STORE(:INITIALIZE) mechanism
yet.  Fixes R#2509
@lizmat lizmat self-assigned this Feb 8, 2019
@lizmat
Copy link
Contributor

lizmat commented Feb 8, 2019

Fixed with ada116e . Since this was caught by tests, I guess we don't need any further tests?

@lizmat lizmat added tests needed Issue is generally resolved but tests were not written yet and removed BLOCKER Preventing the next release of rakudo, or just needing attention before the release labels Feb 8, 2019
@Kaiepi
Copy link
Contributor

Kaiepi commented Feb 10, 2019

The fix for this is breaking tests on IO::Socket::Async::SSL because of this error:

> my CArray[CArray[uint32]] $a .= new: CArray[uint32].new(1),CArray[uint32].new(2)
CArray of CArray passed non-CArray object
  in method ASSIGN-POS at /home/morfent/Documents/perl6/rakudo/lib/NativeCall/Types.pm6 (NativeCall::Types) line 181
  in method new at /home/morfent/Documents/perl6/rakudo/lib/NativeCall/Types.pm6 (NativeCall::Types) line 235
  in method new at /home/morfent/Documents/perl6/rakudo/lib/NativeCall/Types.pm6 (NativeCall::Types) line 230
  in block <unit> at <unknown file> line 1

@jonathanstowe
Copy link
Contributor

It also appears to be the culprit in #2687

@lizmat
Copy link
Contributor

lizmat commented Feb 10, 2019

Will look at this later tonight

@lizmat
Copy link
Contributor

lizmat commented Feb 10, 2019

Sorry, it will be tomorrow. Been too busy with too many other things to get the right mindset for this.

@AlexDaniel AlexDaniel added the BLOCKER Preventing the next release of rakudo, or just needing attention before the release label Feb 12, 2019
@lizmat
Copy link
Contributor

lizmat commented Feb 12, 2019

Better fix with 5e5c909

@lizmat
Copy link
Contributor

lizmat commented Feb 12, 2019

Argh... it doesn't fix this one :-(

@lizmat
Copy link
Contributor

lizmat commented Feb 12, 2019

Removed original fix with 30fc514 to unbreak associated tickets

@AlexDaniel AlexDaniel added BLOCKER Preventing the next release of rakudo, or just needing attention before the release and removed BLOCKER Preventing the next release of rakudo, or just needing attention before the release labels Feb 12, 2019
@lizmat
Copy link
Contributor

lizmat commented Feb 12, 2019

Properly fixed with 84ed854

@lizmat lizmat removed the BLOCKER Preventing the next release of rakudo, or just needing attention before the release label Feb 12, 2019
MasterDuke17 referenced this issue Feb 12, 2019
Which should at least unbreak R#2687 and associated
@lizmat
Copy link
Contributor

lizmat commented Feb 12, 2019

Tests added with b394b63 after fixing the Blob.new case as well with 05b9aa0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue did not exist previously tests needed Issue is generally resolved but tests were not written yet
Projects
None yet
Development

No branches or pull requests

5 participants