Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$p is Mu #2773

Closed
taboege opened this issue Mar 19, 2019 · 5 comments

Comments

Projects
None yet
5 participants
@taboege
Copy link
Contributor

commented Mar 19, 2019

The Problem

There seems to be a lexial $p declared and Mu:

say $p
#= (Mu)

Other names such as $res and $iter are also affected. @ugexe (https://colabti.org/irclogger/irclogger_log/perl6?date=2019-03-19#l741) found this commit: https://github.com/rakudo/rakudo/blob/774ec5a0cb3e00fa4f5159228f540632277f2d30/src/core/signals.pm6

#2366 seems to result from the same thing.

@ugexe

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

( my $res := nqp::hash ),
( my $iter := nqp::iterator(nqp::getsignals) ),
nqp::while(
$iter,
nqp::stmts(
( my $p := nqp::shift($iter) ),

@lizmat lizmat self-assigned this Mar 19, 2019

@lizmat

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Fixed with 76b6416 . Not sure how to test this.

@jnthn

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@lizmat If nothing else, a Rakudo test that checks everything in CORE::.keys falls within a whitelist of things we're OK with, so we know if another accidentally slips in.

@lizmat

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Test added with 4825f31 . Should we do this also with SETTING:: PROCESS:: and the like?

@lizmat

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Added tests for keys in SETTING:: and PROCESS:: with 9399ea1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.