Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix stuck precomp on osx #1076
From the patch I assume that the issue was that there was output on STDERR during the compilation, but the compilation did not actually fail, so we did not read all STDERR output in this case somehow causing the hang?
The patch looks absolutely OK. I would just like the commit message to answer the above question.
I can't answer that question, as I don't know why it works. I've just done a similar pattern more than once over the years having encountered osx + proc issues before.
In this case
I golfed this down, and it affects more than just osx:
A comment from irc explaining what is likely happening:
May 6, 2017
fwiw I RT'd the above behaviour on OSX a while ago: