Move and refactor the multi-dim candidates of postcircumfix { } #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move them to multidim_slice.pm, where the postcircumfix[;] ones have already been moved last year with commit bb662ff.
…rcumfix[;]
postcircumfix[;] has seen significant refactors/optimizations, but
postcircumfix{;} was seemingly left behind. This commit brings it in
line (though only the default candidate for now, i.e. without
adverbs or binding.)
It now passes multiple arguments to .AT-KEY in case of mutidimensional
scalar subscripts, just like .[] already did with .AT-POS.
The default implementations of the *-KEY methods provided by class
Any have been updated to handle this.
(This also fixes RT #130947)
The other associative classes (Map, Hash, Pair, etc.) inherit the default implementation from Any, but role TypedHash overrides it so it has to call the multi-dim Any candidate manually.
Multi-dimensional postcircumfix [ ] returned a slice (List) instead
of a scalar element, unless the key at every dimensions was an Int.
(Same with postcircumfix { } and Str, since commit 2faed16.)
That was incorrect. Now, a slice is only returned if any dimension
has an Iterable or Whatever/HyperWhatever key.
Example test-case that now passes:
my @A = [1, [[2, 3, 4], 5, [6, 7]]];
is-deeply @A[1; 0.0; "2"], 4, 'indices are coerced to integers';
|
Can you please have a look at this? It's got conflicts with the new base. |
JJ
added
consistency
easy to resolve
|
The array issue appears to have been resolved with 2017.12. The hash issue still exists. But since I have recently re-imagined array slices, and am looking at re-imagining hash slices, I think this PR can be closed. The issue should remain open though. |
|
Closing this PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to implement them more similarly to the multi-dim candidates of postcircumfix [ ].
This fixes:
Testing
make spectestfor me (run on Rakudo Moar).