turn Wval to Want after compile-time-evaluating pure ops #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the spectests all succeed. |
| @@ -396,6 +410,25 @@ class Perl6::Optimizer { | |||
| if $op.named { | |||
| $wval.named($op.named); | |||
There was a problem hiding this comment.
Do I want to move this down to after return $want? Or is it okay to have the .named on the WVal as well as the Want that contains it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the optimizer turns literals like -5 into a WVal(-5), which is better than the previous call to prefix:<-> + Want(5), but now it's no longer a Want and cannot be used to dispatch to subs that take native values.
This branch creates a Want for Int, Num and Str results of compile-time evaluation in the Optimizer.
The changes have passed spectests on my machine, but then i re-arranged some commits and pulled in some recent changes, so i'll run the spectests again.