Fix table caption RT #126740 #1291
Conversation
|
The changes to Actions.nqp were required to get rid of a conflict—they have no part in my PR. It may be because my github fork was using the nom branch as default—I just changed it to master. I tried to get the $.caption var set with a TWEAK submethod but couldn’t make it work. |
|
Note the caption quote issue is another two bugs: RT #126742 and RT #130477. The quotes probably should be removed in Grammar.nqp, but could also be removed in Pod.nqp (in sub make_config). |
|
What'd be the output of |
|
output of bar<“meow”>? good question—I’ll add to tests and see... output is: “meow” surprising, but maybe not with various escaping of quotes in strings... |
|
I don't think I like it. So What would it take to make it not do that? |
|
I don’t know. As Zoffix pointed out the scary TODO comments indicate some fragile handling—and I don’t yet understand how the value is actually extracted. I will play around with other nqp code to see how various things work... I’m getting a glimmer of understanding, and I may be able to eventually determine when the <> is being used, but I don’t have enough time to work on this now. However, the quick fix as it is should take care of most issues since using something like :bar<“meow”> is a little unusual IMHO. I think you should take my fix after I add a TODO to take care of those corner cases later. |
|
TODO Update affected tickets to show incompleteness of fixes. Or, better, consolidate the tickets into one (and add number in code TODOs). |
|
⚠⚠⚠ Rerevert Raku/roast#363 once this PR is merged (it was merged a bit too early by mistake, then reverted) |
|
I’m closing this PR for now and will resubmit later in improved form. |
appropriate tests are in a roast PR