Drop extraneous spaces in code and table blocks #1307
Conversation
|
There are no spec tests for Pod::To::Text. However, I have run this over all the pod in p6doc/doc, and verified that it looks good. |
|
AppVeyor failures are due to another issue (can be ignored). 👍 on the PR, looks good. But can we have some tests for the fixed issues? I think that's important because eventually POD stuff may be refactored, so it'd be sad to lose some of the fixes just because there are no tests. |
AlexDaniel
added
the
tests needed
softmoth
force-pushed
the
pod-text-newlines
branch
from
027f91f
to
dcab5d9
Compare
|
Alex, thank you for the review. I've added a new t/07-pod-to-text/01-whitespace.t file. |
code2text() was missing a .join call, so inserted extra spaces between chunks (e.g. around embedded formatting codes). table2text() was padding the final column in each row, which is not desirable in a plain text format.
softmoth
force-pushed
the
pod-text-newlines
branch
from
dcab5d9
to
8ea7a46
Compare
|
I wonder though, what's the reason for these tests to not be in roast? Are these really implementation-specific? |
|
I am pretty sure they don't belong in roast. Initially I put the file in spec/MISC, but it feels wrong to put in roast as the output isn't specified and to me it shouldn't be part of the language definition. If that's not consensus then I'm okay putting it anywhere, just let me know where it belongs. |
|
We can move it later. |
code2text() was missing a .join call, so inserted extra spaces between
chunks (e.g. around embedded formatting codes).
table2text() was padding the final column in each row, which is not
desirable in a plain text format.