Issue 1341: Elevate statevars to enclosing block when wrapped #1467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in some blocks following the "do" statement prefix, statevars
would be seemingly reset after each iteration of the loop.
Given the statement:
This statement would result in multiple thunk refs being produced, and
ultimately, would be wrapped in a block that is used as a cloning target
in looping and a new container would be declared and initialized for
each iteration.
The QAST would look like this (trimmed to relevant parts):
After this commit the QAST looks like this:
This way the statevar is declared in the block being cloned and thus the
same container is used in each iteration.
Note the enclosing block is a block newly created via the make_thunk_ref sub,
and contains no child nodes other than the first Stmts (that has no children prior
to this commit) and the second Stmts containing the cuid(1) subtree.
See Github Issue 1341