Make Hash.new() and hash() accept the same typed parameters as .hash() #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spectests ok except for t/spec/S04-statement-parsing/hash.t test 6+7 Please note that according to S04:1639 and S06:3298, tests 6+7 are actually wrong. They just happen to be right for the previous implementation of hash().
But this feels more what people want / expect. So this will only leave Hash.new with a new API.
|
After discussions, we're going to do it another way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spectests ok except for t/spec/S04-statement-parsing/hash.t test 6+7
Please note that according to S04:1639 and S06:3298, tests 6+7 are
actually wrong. They just happen to be right for the previous implementation
of hash().