Support for subscript adverb :delete in combination with :kv :p :k :v #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in S02:2514
|
I hope this merges cleanly: to be honest, I've lost track of which pull requests have already been merged, and which ones haven't. Hope we can sort this out at the PLPW at the latest! |
Conflicts: src/core/Any.pm
After discussing this with jnthn at PLPW
lizmat
added a commit
that referenced
this pull request
Jun 2, 2013
Support for subscript adverb :delete in combination with :kv :p :k :v
zoffixznet
added a commit
that referenced
this pull request
Jun 2, 2017
Fixes RT#131479: https://rt.perl.org/Ticket/Display.html?id=131479 Fixes roast/#158: Raku/roast#158 The observed problems are due to multiple .kills in separate threads ending up calling $*KERNEL.signal, which isn't thread safe, ending up in it returning a type object, crashing due to return type constraint Fix by first refactoring[^1] $*KERNEL.signal so only the Str:D candidate is not thread safe and then refactoring Proc::Async.kill to use multies for non-Str signals, so we don't have to use $*KERNEL.signal for those, as for Str signals, we use a lock when calling $*KERNEL.signal, avoiding race issues. [1] 79b8ab9d3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in S02:2514. Spectested.
This should fix a few TODO tests. Needs more tests, will do when this is done.