Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1843: Limit slice end index in splice implementation #1845

Merged
merged 1 commit into from May 20, 2018

Conversation

Projects
None yet
2 participants
@jstuder-gh
Copy link
Contributor

commented May 20, 2018

Splice allows the user to enter a number of elems greater than the elems
in the list (the extra is just ignored). However, nqp::slice throws an
exception if too large an index is submitted. Check that the end index
is not greater than the total elems.

Limit slice end index in splice implementation
Splice allows the user to enter a number of elems greater than the elems
in the list (the extra is just ignored). However, nqp::slice throws an
exception if too large an index is submitted. Check that the end index
is not greater than the total elems.

zoffix++ for suggestion to reuse existing 'removed' value.

@zoffixznet zoffixznet merged commit 4537a8e into rakudo:master May 20, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@zoffixznet

This comment has been minimized.

Copy link
Contributor

commented May 20, 2018

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.