Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Allow more windows environments with git to work correctly with build process #19

Closed
wants to merge 4 commits into from

2 participants

Jimmy Zhuo Moritz Lenz
Jimmy Zhuo

this fixed build problem on windows with sysgit.
see http://trac.parrot.org/parrot/ticket/1865 for detail.

Jimmy Zhuo

hm, I only pull zhuomingliang@c3dcbbe , others are unused.

Moritz Lenz
Owner

I see no further mention of SHELL in the Makefile. Why is it necessary to set that variable?

Jimmy Zhuo

moritz, if not, anyone who installed sysgit on windows can't build rakudo.

Jimmy Zhuo

see http://www.gnu.org/prep/standards/html_node/Makefile-Basics.html#Makefile-Basics , it says 'avoid trouble on systems where the SHELL variable might be inherited from the environment'

Moritz Lenz
Owner

applied as c3dcbbe, thanks

Scott Penrose scottp referenced this pull request from a commit in scottp/rakudo
Patrick R. Michaud pmichaud Fill in a release name for #19 (Chicago) ee402a7
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 23, 2011
  1. removed unneeded S32-str/split-simple2.t

    Jimmy Zhuo authored
Commits on Feb 26, 2011
  1. removed *.notdef

    Jimmy Zhuo authored
Commits on Mar 8, 2011
  1. fixed windows build

    Jimmy Zhuo authored
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +1 −0  Configure.pl
  2. +1 −0  build/Makefile.in
1  Configure.pl
View
@@ -158,6 +158,7 @@ sub create_makefile {
my $maketext = slurp( 'build/Makefile.in' );
+ $config{'shell'} = $^O eq 'MSWin32' ? 'cmd' : 'sh';
$config{'stagestats'} = $makefile_timing ? '--stagestats' : '';
$config{'win32_libparrot_copy'} = $^O eq 'MSWin32' ? 'copy $(PARROT_BIN_DIR)\libparrot.dll .' : '';
$maketext =~ s/@(\w+)@/$config{$1}/g;
1  build/Makefile.in
View
@@ -1,6 +1,7 @@
# Copyright (C) 2006-2010, The Perl Foundation.
# $Id$
+SHELL = @shell@
PARROT_ARGS =
# values from parrot_config
Something went wrong with that request. Please try again.