Fix is-lazy propagation bug in List::Reifier #2493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triangle reduce was not recognizing Lists containing lazy Slips as lazy. This can be tracked back to the is-lazy method on List::Reifier (and was ultimately being propagated up to the triangle reduce routine). is-lazy in List::Reifier was not considering the possibility of lazy Slips. Fix this by having the method check any $!future elements it may have for laziness. See [Github Issue rakudo#2122](rakudo#2122)
|
Pushed up one more commit. The previous one was a bit too overzealous in declaring the resulting
|
lizmat
added a commit
that referenced
this pull request
Mar 2, 2019
To fix at least laziness check on [\+] Jeremy Studer++ for PR
|
Thank you for your work. Since there was no reply to my comment and we're 3 months later now, I decided to take the idea and re-imagine it with 8f424c9. |
Kaiepi
pushed a commit
to Kaiepi/rakudo
that referenced
this pull request
Mar 7, 2019
To fix at least laziness check on [\+] Jeremy Studer++ for PR
Kaiepi
pushed a commit
to Kaiepi/rakudo
that referenced
this pull request
Mar 10, 2019
To fix at least laziness check on [\+] Jeremy Studer++ for PR
lizmat
added a commit
that referenced
this pull request
Jun 1, 2019
This reverts commit 8f424c9. Not seeing a way to fix this atm, so reverting and re-opening the pull request on which this was based (as well as the issue that caused this).
|
Reverted my version of the PR as it caused a regression: #2920 . |
Kaiepi
pushed a commit
to Kaiepi/rakudo
that referenced
this pull request
Jun 5, 2019
This reverts commit 8f424c9. Not seeing a way to fix this atm, so reverting and re-opening the pull request on which this was based (as well as the issue that caused this).
|
Can you please fix the conflict and continue here? |
|
Closing this PR as my re-imagining didn't work out, and this PR didn't get its conflicts solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triangle reduce was not recognizing Lists containing lazy Slips as lazy.
This can be tracked back to the is-lazy method on List::Reifier (and was
ultimately being propagated up to the triangle reduce routine). is-lazy
in List::Reifier was not considering the possibility of lazy Slips. Fix
this by having the method check any $!future elements it may have for
laziness.
See Github Issue #2122