Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

The new GC needs write barriers for certain ops #26

Merged
merged 1 commit into from

3 participants

@atrodo

This is a patch by bacek++ that allows rakudo to build and run on some systems, in particular, my system running the tests for isparrotfastyet.com. Without this, rakudo will not build because of a "dead object found" error. The system is lower memory (512M), which probably exacerbates the problem, but any system could see this error.

@rakudo rakudo merged commit 1c91ecb into rakudo:master
@pmichaud
Owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 11 additions and 0 deletions.
  1. +11 −0 src/ops/perl6.ops
View
11 src/ops/perl6.ops
@@ -154,6 +154,9 @@ inline op rebless_subclass(in PMC, in PMC) :base_core {
memmove(value, new_ins, sizeof (PMC));
memmove(new_ins, temp, sizeof (PMC));
+ /* Trigger writebarrier after poking into guts directly */
+ PARROT_GC_WRITE_BARRIER(interp, value);
+
Parrot_unblock_GC_mark(interp);
mem_sys_free(temp);
@@ -171,6 +174,9 @@ inline op rebless_subclass(in PMC, in PMC) :base_core {
"Object to be reblessed does not appear to be of the expected class.");
}
else {
+ /* Block GC before fiddling with C<value> guts to avoid multiple WBs */
+ Parrot_block_GC_mark(interp);
+
/* We have a standard Parrot class and object and can tweak it's guts.
* Shuffle up attributes to the point of the difference between the number
* of attributes in the parent and the derived class. Yes, this is evil -
@@ -182,6 +188,11 @@ inline op rebless_subclass(in PMC, in PMC) :base_core {
/* Now switch object's class pointer to point at the new class. This is
* also evil. */
PARROT_OBJECT(value)->_class = $2;
+
+ /* Trigger writebarrier after poking into guts directly */
+ PARROT_GC_WRITE_BARRIER(interp, value);
+
+ Parrot_unblock_GC_mark(interp);
}
goto NEXT();
Something went wrong with that request. Please try again.