Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate a been_tapped race. #274

Closed
wants to merge 1 commit into from
Closed

Eliminate a been_tapped race. #274

wants to merge 1 commit into from

Conversation

donaldh
Copy link
Contributor

@donaldh donaldh commented Jun 3, 2014

This resolves the race condition between more and first tap.

@donaldh
Copy link
Contributor Author

donaldh commented Jun 3, 2014

[23:26] jnthn donaldh: oh, but I don't like/want that solution
[23:26] donaldh oh.
[23:26] donaldh Well it corrects the current solution
[23:26] jnthn Yeah, but it adds a dependency on something I don't think is the right way to solve the problem...
[23:27] donaldh okay. np
[23:27] lizmat could we at least pull this? so at least this solution doesn't race ?
[23:27] jnthn Knowing that fixes it for you is worthwhile, though...since it means the thing I have in mind (Supply.on_demand(-> $s { ... }) will do it.
[23:27] donaldh I didn't realise you had bigger change planned.
[23:28] lizmat so, shall I pull it ? For now ?
[23:28] jnthn lizmat: So I can revert it and replace it in a day or two's time?
[23:28] donaldh It allows me to get on with writing spectests for Async io
[23:28] jnthn donaldh: True, though you could do that with it applied locally
[23:28] donaldh Yep. Happy to.
[23:29] lizmat if it's only a day or two, then by all means, don't let me stop you
[23:29] jnthn Yeah. I have a full day for Perl 6 things on Thursday so can certainly get to it then.
[23:30] lizmat cool
[23:30] donaldh jnthn++

@donaldh donaldh closed this Jun 3, 2014
AlexDaniel added a commit that referenced this pull request Jul 24, 2018
NQP bump brought: Raku/nqp@2018.06-70-gcaf545127...2018.06-72-g3a4cbe042
3a4cbe042 [MoarVM Bump] Brings 4 commits
15c977471 unfudge test, co #274 (#485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant