Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tr #284

Merged
merged 1 commit into from Jul 12, 2014
Merged

Implement tr #284

merged 1 commit into from Jul 12, 2014

Conversation

peschwa
Copy link
Member

@peschwa peschwa commented Jun 30, 2014

@moritz
Copy link
Member

moritz commented Jul 1, 2014

Sorry to not have a more useful comment, but you seem to have some debug output left in method Int.

StrDistance takes the untransliterated and transliterated Strings as
constructor arguments and implements .Bool, .Int and .Numeric. Numeric
defers to .Int, which calculates the replaced characters on invocation.
Bool returns True if any transliteration has occured, False otherwise.
@peschwa
Copy link
Member Author

peschwa commented Jul 11, 2014

Rebased it down to one commit in a fit of wanting to make it neater. The debug output is gone, the method itself as well. It got replaced with a new class StrDistance which is described in the commit message as follows, and hopefully actually does what I described. :)

StrDistance takes the untransliterated and transliterated Strings as
constructor arguments and implements .Bool, .Int and .Numeric. Numeric
defers to .Int, which calculates the replaced characters on invocation.
Bool returns True if any transliteration has occured, False otherwise.

@peschwa
Copy link
Member Author

peschwa commented Jul 12, 2014

This gist has my spectest results. There were run with current roast and the branch for this PR with newer commits merged.

@jnthn jnthn merged commit 023a907 into rakudo:nom Jul 12, 2014
@peschwa peschwa deleted the implement_tr branch July 12, 2014 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants