Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't special case OpenBSD in relocatability handling #2857

Merged
merged 2 commits into from May 13, 2019

Conversation

patrickbkr
Copy link
Contributor

Relocatability is disabled entirely on OpenBSD, because of technical
difficulties. So no need to put hacks in to make it work in relocatable
mode.
Also simplify logic a bit more. Should still do the same as before.

@Kaiepi
Copy link
Contributor

Kaiepi commented May 6, 2019

Regardless of whether or not the executable is relocatable, nqp::execname is still being used when it returns a random flag passed to moar on OpenBSD. I don't think what you're trying to do here will work on OpenBSD without changing MVM_execname in MoarVM to return an empty string, but that behaviour would be coupling.

Cleaning up the code here is good, but I don't think you can entirely get rid of the hack. I'd write something like this to get this to work:

my $execname := $*VM.osname eq 'openbsd' ?? '' !! nqp::execname();

Relocatability is disabled entirely on OpenBSD, because of technical
difficulties. So no need to put hacks in to make it work in relocatable
mode.
Also simplify logic a bit more. Should still do the same as before.
nqp::execname() is not '' in OpenBSD thus we still need some special
casing. Kaiepi++ for the hint.
@patrickbkr patrickbkr merged commit bd89d51 into rakudo:master May 13, 2019
@patrickbkr patrickbkr deleted the openbsd-cleanup branch June 11, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants