Attempt to fix SupplyOperation weirdness #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch creates an issue where calling .close on one tap will end up closing the source tap for all taps. This could possibly be solved by still having a separate source_tap per tapper, but only passing messages to that tapper instead of to all of them. However, I don't know enough to understand what the best solution is yet. |
Spotted and suggested by retupmoca++ . Basically, a new internal tap was being created for each tap on the outside: now only the first outside tap creates an internal tap.
|
lizmat++ |
This reverts commit 9a1c529.
Each source_tap now only passes messages on to that one client tap, not all of them.
|
Attempt 2: only pass source_tap messages to our calling tap, not to every tap. |
|
Github is confused - will open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing, for example, $s2 = $supply.grep(* == 1); $s2.tap(...);
$s2.tap(...); $supply.more(1); # would run both taps twice
See http://irclog.perlgeek.de/perl6/2014-07-09#i_8998922 and
http://irclog.perlgeek.de/perl6/2014-07-10#i_8998982 for camelia
examples.