Implement tr #317
Closed
Implement tr #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peschwa
force-pushed
the
implement_tr
branch
3 times, most recently
from
df5fcbe
to
694ab03
Compare
|
Rebasing the branch against the mentioned performance improvements seems to have made the previous discussion disappear. I have addressed the issue raised within though. The comment at time of creation of the PR still applies, there's only one test remaining as |
peschwa
force-pushed
the
implement_tr
branch
from
694ab03
to
8d5e38e
Compare
Adverbs for tr/// work and are implemented as named parameters for Str.trans, which obviously supports the same ones. :squash and :delete are implemented decently (IMHO), while :complement isn't at all at present.
|
I've merged and fixed this myself now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ok rather, implement a few more features that tr/// and .trans should have.
Those are adverbs for tr/// and .trans as well as closures as replacement. Additionally I have fixed the bug discovered/discussed around here.
Remaining TODO in t/spec/S05-transliteration/trans.t is
not ok 23 - ambiguous ranges combined# TODO disambiguate ranges, which I hereby defer judgement over.