Only pass on capture in sub split if it's there
#3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise spesh can't intern the callsite and then the jit bails. Other attempts (i.e., adding a new `multi sub split($pat, Cool:D $target)`, or adding that and also changing the `|c` in the other multi to `*%h`) caused errors like `Unexpected named argument 'v' passed` and `Ambiguous call to 'split(Str, Str, :v)'; these signatures all match::($pat, Cool:D $target):($pat, Cool:D $target, *%h)`. Found when playing around with the code referenced in rakudo#3281 and makes it slightly faster.
jnthn
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise spesh can't intern the callsite and then the jit bails. Other
attempts (i.e., adding a new
multi sub split($pat, Cool:D $target), oradding that and also changing the
|cin the other multi to*%h)caused errors like
Unexpected named argument 'v' passedandAmbiguous call to 'split(Str, Str, :v)'; these signatures all match::($pat, Cool:D $target):($pat, Cool:D $target, *%h). Found when playing aroundwith the code referenced in #3281 and makes it slightly faster.
Rakudo builds ok and passes
make m-test m-spectest.