Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RT #124204 in squish: Do not .Str the return value of &as, in order ... #400

Closed
wants to merge 1 commit into from

Conversation

edwinst
Copy link
Contributor

@edwinst edwinst commented Apr 1, 2015

...to

keep objects distinguishable for the comparison operator used (=== by default).

…er to

keep objects distinguishable for the comparison operator used (=== by default).
@moritz
Copy link
Member

moritz commented Aug 2, 2015

Currently this branch doesn't merge cleanly, probably because the function was switched from gather/take to .map for performance reasons.

Could you please rebase it against current nom?

@AlexDaniel
Copy link
Contributor

The ticket is marked as resolved. Hey @usev6, can you take a look?

@usev6
Copy link
Contributor

usev6 commented Mar 28, 2018

Yes, this PR is no longer needed. Commit 24931c4 from 2015-09 did exactly the same thing as this PR -- except that $which was not renamed to $as.

Even so, thanks to @edwinst .

@usev6 usev6 closed this Mar 28, 2018
@AlexDaniel
Copy link
Contributor

@usev6 thank you for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants