Workaround RT#120919 to fix Date/Temporal on JVM backend #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VALID-UNITS method cannot be both private and in a role on JVM due to RT#120919. Also the crash caused by this bug is nasty because it kills the stack trying to build exceptions inside exceptions due to repeated failure to bind '$?CLASS' to typed exception attributes.
|
Can we leave a code comment somewhere to revert this when RT#120919 -- otherwise someone is going to wonder why private-looking methods are leaking. |
|
I was going to upload such a comment to roast. But then I figured maybe best to post it in the RT? Have not decided yet. In addition to src/core/Temporal.pm there is a pre-existing workaround in src/core/IO/Local.pm. |
|
OK, I added a comment in the RT ticket saying what to do to remove workarounds. |
|
Bug long since resolved and it looks like this workaround was removed as VALID-UNIT is back to a private method now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VALID-UNITS method cannot be both private and in a role on JVM
due to RT#120919. Also the crash caused by this bug is nasty because
it kills the stack trying to build exceptions inside exceptions due
to repeated failure to bind '$?CLASS' to typed exception attributes.