One more fixmas indentation fix and improvement on previous fix #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat actual backslash sequences inside a heredoc similarly to interpolated strings so they do not cause indentation in the middle of a line (but only when they include vertical whitespace.)
Note that this should probably not cause Windows issues as \r\n is a blank line and as such is ignored, but this bears testing (and appreciation of crafty language designers.)
When writing spectests for 12db6c0 I noticed a corner case that was not giving visually consistent results. Also now that we delete from the front the code was not arranged very logically. Refactor to take advantage of rx features and take substrings of the original input rather than splitting/rejoining character-by-character. The corner case was that a tab appearing in the uncut portion of the whitespace would not move during an uneven dedent. Now, enough space is removed from the front to assure the remaining tabs notch in one tabstop, then extra padding is added to the end to compensate for their movement.
|
Worth noting is that $?TABSTOP seems destined to be a (localizable) |
|
ping does this still need to go in or can this PR be closed? There are some conflicts. |
|
Well, there were conflicts already in 2016. I don't think this can be fixed, closing. |
|
This PR claims to resolve RT#125543 but it is already closed: Raku/old-issue-tracker#4378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.