Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typed exception X::Hash::Store::OddNumber #59

Merged
merged 2 commits into from Feb 28, 2012
Merged

typed exception X::Hash::Store::OddNumber #59

merged 2 commits into from Feb 28, 2012

Conversation

Siddhant
Copy link
Contributor

No description provided.

moritz added a commit that referenced this pull request Feb 28, 2012
typed exception X::Hash::Store::OddNumber
@moritz moritz merged commit 83b15cd into rakudo:nom Feb 28, 2012
@@ -325,3 +325,7 @@ my class X::Routine::Unwrap is Exception {
my class X::Constructor::Positional is Exception {
method message() { "Default constructor only takes named arguments" }
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moritz, just read your blog post. Cool.

Question: what is the idea behind having all exception classes declared in a central file and not locally?

cheers
tobi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oetiker,

The advantage of having exception classes declared centrally is that it's easier to find them all and perhaps thus helps in easy localizations (translations).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ease of grabbing strings for localization from source seems seems to be an odd reason for moving away from the well proven approach of keeping things together that work together ... eg documentation and code (see POD) ... so keeping all the exceptions in a separate tree seems odd, especially when I think of adding new exceptions for my own classes, or would that work differently ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants