Use distribution's name to find binary resources #625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when a distribution has binary/script files, we install them as resources owned by the distribution, as well as wrapper scripts that the shell can find via PATH that use the CompUnit API to dispatch to the corresponding resource. Some distributions install multiple binaries; for example, panda installs panda, panda-build, panda-test, etc. The wrapper scripts currently use the basename of the wrapper script to locate the distribution that contains the corresponding binary resource, rather than the name of the distribution that binary is a part of. This change makes wrapper scripts use the distribution name to find dist metadata, which will then be used to locate the resource for the actual binary.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a distribution has binary/script files, we install them
as resources owned by the distribution, as well as wrapper scripts that
the shell can find via PATH that use the CompUnit API to dispatch to
the corresponding resource.
Some distributions install multiple binaries; for example, panda
installs panda, panda-build, panda-test, etc. The wrapper scripts
currently use the basename of the wrapper script to locate the
distribution that contains the corresponding binary resource, rather
than the name of the distribution that binary is a part of.
This change makes wrapper scripts use the distribution name to find dist
metadata, which will then be used to locate the resource for the actual
binary.