IO Buffering #71
Closed
IO Buffering #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,6 +111,13 @@ class IO does IO::FileTestable { | |||
| Bool::True; | |||
| } | |||
|
|
|||
| # XXX - DESTROY is NYI in Rakudo at the time this was written, so | |||
| # the following has no effect. | |||
| method DESTROY() { | |||
There was a problem hiding this comment.
now implemented in rakudo-moar; but it should be submethod, not a method.
|
Because this PR reaches down into Parrot internals, and Parrot support has been suspended, I'm closing this pull request. If Parrot support returns in the future, this should probably be implemented with nqp op(s). |
|
I gave up on this one a long time ago, and am happy to see it closed. Real IO support in Perl6 is going to be a major undertaking, and I don't think that it behooves the language to take it on piecemeal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two methods for doing buffering of IO handles and turned on line buffering by default on new handles.