Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the behaviour of require WRT to global symbols #714

Merged
merged 1 commit into from Feb 17, 2016

Conversation

jonathanstowe
Copy link
Contributor

Recent changes in require meant that code that did a require in an inner lexical scope were not having the symbols merged in such a way that they could be found by an indirect lookup, this broke for instance, the way that Panda dealt with the Build.pm files

jonathanstowe added a commit to Raku/roast that referenced this pull request Feb 17, 2016
rakudo/rakudo#714

That is, if a module is required in an inner scope then the
global symbols aren't available by indirect lookup.
jnthn added a commit that referenced this pull request Feb 17, 2016
Fix the behaviour of require WRT to global symbols
@jnthn jnthn merged commit 6159b5e into rakudo:nom Feb 17, 2016
@ugexe
Copy link
Member

ugexe commented Feb 17, 2016

This PR allows IO::Socket::SSL to be installed again, which reveals more incorrect behavior:

nickl@li685-90:~/perl6$ perl6 -v
This is Rakudo version 2015.12-323-gbb2953c built on MoarVM version 2016.01-28-g2136293
implementing Perl 6.c.

nickl@li685-90:~/perl6$ perl6 -e 'require IO::Socket::SSL; say 42; say (try require IO::Socket::SSL);'
42
(SSL)

nickl@li685-90:~/perl6$ perl6 -v
This is Rakudo version 2015.12-380-g6159b5e built on MoarVM version 2016.01-28-g2136293 implementing Perl 6.c.

nickl@li685-90:~/perl6$ perl6 -e 'require IO::Socket::SSL; say 42; say (try require IO::Socket::SSL);'
42
Nil

LLFourn added a commit to Raku/roast that referenced this pull request Feb 20, 2016
So the following doesn't happen accidentally to IO::Socket::SSL again
rakudo/rakudo#714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants