Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix for missing parrot phony.exe under cygwin per RT #113992 #74

Closed
wants to merge 1 commit into from

2 participants

ronaldxs Patrick R. Michaud
ronaldxs

No description provided.

Patrick R. Michaud
Owner

The pull request puts the fix in the wrong place, unfortunately. First, I think the fix belongs in Parrot, not Rakudo -- see updated comments in RT #113992.

Even if it turns out that Rakudo needs to supply a workaround, this is going to be the wrong place to do it. The NQP::Configure module is intended to be shared by NQP, Rakudo, and other languages to be built on top of NQP, so doing repairs of Parrot's tarball hopefully doesn't belong in this (shared) library. I'd be more likely to accept it as a fix in Star's Configure.pl (but I still think it's a Parrot bug that should be fixed in the Parrot tarball).

Pm

Patrick R. Michaud pmichaud closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 8 additions and 0 deletions.
  1. +8 −0 tools/lib/NQP/Configure.pm
8 tools/lib/NQP/Configure.pm
View
@@ -2,6 +2,7 @@ package NQP::Configure;
use strict;
use warnings;
use Cwd;
+use File::Copy;
use base qw(Exporter);
our @EXPORT_OK = qw(sorry slurp system_or_die
@@ -338,6 +339,13 @@ sub gen_parrot {
}
}
+ # Compensate for cygwin removal of phony.exe per RT #113992
+ my $phony_dir = 't/tools/install/testlib';
+ if (not -f "$phony_dir/phony.exe" and -f "$phony_dir/phony") {
+ copy("$phony_dir/phony", "$phony_dir/phony.exe") or
+ die "Could not copy/create $phony_dir/phony.exe: $!";
+ }
+
$prefix =~ s{\\}{/}g;
print "\nConfiguring Parrot ...\n";
Something went wrong with that request. Please try again.