Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Fix for missing parrot phony.exe under cygwin per RT #113992 #74

Closed
wants to merge 1 commit into from

2 participants

ronaldxs Patrick R. Michaud
ronaldxs

No description provided.

Patrick R. Michaud
Owner

The pull request puts the fix in the wrong place, unfortunately. First, I think the fix belongs in Parrot, not Rakudo -- see updated comments in RT #113992.

Even if it turns out that Rakudo needs to supply a workaround, this is going to be the wrong place to do it. The NQP::Configure module is intended to be shared by NQP, Rakudo, and other languages to be built on top of NQP, so doing repairs of Parrot's tarball hopefully doesn't belong in this (shared) library. I'd be more likely to accept it as a fix in Star's Configure.pl (but I still think it's a Parrot bug that should be fixed in the Parrot tarball).

Pm

Patrick R. Michaud pmichaud closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Jul 04, 2012
ronaldxs Fix for missing parrot phony.exe under cygwin per RT #113992 a700a7f
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 8 additions and 0 deletions. Show diff stats Hide diff stats

  1. 8  tools/lib/NQP/Configure.pm
8  tools/lib/NQP/Configure.pm
@@ -2,6 +2,7 @@ package NQP::Configure;
2 2
 use strict;
3 3
 use warnings;
4 4
 use Cwd;
  5
+use File::Copy;
5 6
 
6 7
 use base qw(Exporter);
7 8
 our @EXPORT_OK = qw(sorry slurp system_or_die
@@ -338,6 +339,13 @@ sub gen_parrot {
338 339
         }
339 340
     }
340 341
 
  342
+    # Compensate for cygwin removal of phony.exe per RT #113992
  343
+    my $phony_dir = 't/tools/install/testlib';
  344
+    if (not -f "$phony_dir/phony.exe" and -f "$phony_dir/phony") {
  345
+        copy("$phony_dir/phony", "$phony_dir/phony.exe") or
  346
+            die "Could not copy/create $phony_dir/phony.exe: $!";
  347
+    }
  348
+
341 349
     $prefix =~ s{\\}{/}g;
342 350
 
343 351
     print "\nConfiguring Parrot ...\n";
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.